Vouchers, which help people afford rent, have long been seen as a key to solving the nation’s housing woes. But in New York City, a broken oversight system is undermining their effectiveness, advocates say.